Skip to content

chore: remove Docker remnants + dead shell scripts (closes #59) - #70

Merged
zackees merged 1 commit into
mainfrom
chore/issue-59-non-python-cleanup
May 13, 2026
Merged

zackees merged 1 commit into
mainfrom
chore/issue-59-non-python-cleanup

Conversation

@zackees

@zackees zackees commented May 13, 2026

Copy link
Copy Markdown
Member

Summary

Cleans up the non-Python items issue #59 flagged that survived the prior Python-focused sweeps (PRs #61, #62, #64, #65, #66, #68). All confirmed dead by full-repo grep across *.py, *.rs, *.toml, *.yml, *.sh, *.md, Cargo.toml.

Deleted

  • entrypoint.sh — Docker container entrypoint. Sourced /emsdk/emsdk_env.sh (container path) and invoked fastled_wasm_compiler.cli_update_from_master, a module from a separate package that only exists inside the container.
  • compiler/run.py — Docker compile-server entry point. Imports fastled_wasm_compiler, not in this repo.
  • compiler/debug.sh — instructed user to run from /js (container working dir). Empty compiler/ directory removed too.
  • .dockerignore — contained only **/.mypy_cache/ and **/.ruff_cache/; no Docker build context this could serve.
  • chrome_vscode_bridge_design_task.md — one-off design draft that opens with "Here's a refined ... file for your repo. Feel free to adjust...". Zero references anywhere.
  • upload_package.sh — manual PyPI uploader, superseded by publish_release.yml's automated PyPI publish.
  • Empty root-level fastled/ directory left over from a prior layout.

lint script update

Removed the (now-deleted) compiler/ path from ruff / black / isort / pyright / the keyboard-interrupt checker invocations.

Test plan

  • bash lint clean
  • bash test — 119 pass
  • CI green

Closes #59

🤖 Generated with Claude Code

Sweeps the non-Python items issue #59 flagged that are still on main
after PRs #61, #62, #64, #65, #66, #68 cleaned up the Python side:

* `entrypoint.sh` — Docker container entrypoint. Sourced
  `/emsdk/emsdk_env.sh` (container path) and called
  `fastled_wasm_compiler.cli_update_from_master` (a module from a
  separate package that only exists inside the container).
* `compiler/run.py` — Docker compile-server entry point. Imports
  `fastled_wasm_compiler`, a separate package not in this repo.
* `compiler/debug.sh` — instructed user to run from `/js` (container
  working directory). Empty `compiler/` directory removed.
* `.dockerignore` — only contained cache exclusions
  (`**/.mypy_cache/`, `**/.ruff_cache/`) which belong in `.gitignore`
  if anywhere; no Docker build context this could serve.
* `chrome_vscode_bridge_design_task.md` — one-off design draft that
  opens with "Here's a refined ... file for your repo. Feel free to
  adjust...". Zero references anywhere else.
* `upload_package.sh` — manual PyPI upload helper, superseded by the
  automated `publish_release.yml` workflow. Zero inbound references.
* Empty root-level `fastled/` directory left over from a prior layout.

`lint` script updated to stop passing the (now-deleted) `compiler/` path
to ruff / black / isort / pyright / the keyboard-interrupt checker.

`bash lint` clean. `bash test` — 119 pass.

Verified by grep across `*.py`, `*.rs`, `*.toml`, `*.yml`, `*.sh`,
`*.md`, `Cargo.toml` (excluding `.venv/` and `.claude/worktrees/`):
none of the deleted files are referenced from a live code path or
workflow.
@zackees
zackees merged commit 574d52c into main May 13, 2026
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: remove dead code and Docker remnants leftover from refactors

1 participant